ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fixed LWIP warning issues found by Coverity scan

pull/11023/head
Tymoteusz Bloch 2019-05-23 18:53:44 +02:00 committed by Evelyne Donnaes
parent 390d7cc9f3
commit 6687f41177
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
features/lwipstack/lwip/src/api/lwip_api_msg.c
View File

@ -1332,7 +1332,7 @@ lwip_netconn_do_connected(void *arg, struct tcp_pcb *pcb, err_t err)
conn->state = NETCONN_NONE; conn->state = NETCONN_NONE;
API_EVENT(conn, NETCONN_EVT_SENDPLUS, 0); API_EVENT(conn, NETCONN_EVT_SENDPLUS, 0);
if (was_blocking) { if (was_blocking && op_completed_sem != NULL) {
sys_sem_signal(op_completed_sem); sys_sem_signal(op_completed_sem);
} }
return ERR_OK; return ERR_OK;

5
features/lwipstack/lwip/src/core/ipv4/lwip_ip4_frag.c
View File

@ -206,7 +206,9 @@ ip_reass_free_complete_datagram(struct ip_reassdata *ipr, struct ip_reassdata *p
pbuf_free(pcur); pbuf_free(pcur);
} }
/* Then, unchain the struct ip_reassdata from the list and free it. */ /* Then, unchain the struct ip_reassdata from the list and free it. */
if (prev != NULL) {
ip_reass_dequeue_datagram(ipr, prev); ip_reass_dequeue_datagram(ipr, prev);
}
LWIP_ASSERT("ip_reass_pbufcount >= pbufs_freed", ip_reass_pbufcount >= pbufs_freed); LWIP_ASSERT("ip_reass_pbufcount >= pbufs_freed", ip_reass_pbufcount >= pbufs_freed);
ip_reass_pbufcount = (u16_t)(ip_reass_pbufcount - pbufs_freed); ip_reass_pbufcount = (u16_t)(ip_reass_pbufcount - pbufs_freed);
@ -660,8 +662,9 @@ ip4_reass(struct pbuf *p)
} }
/* release the sources allocate for the fragment queue entry */ /* release the sources allocate for the fragment queue entry */
if (ipr_prev != NULL) {
ip_reass_dequeue_datagram(ipr, ipr_prev); ip_reass_dequeue_datagram(ipr, ipr_prev);
}
/* and adjust the number of pbufs currently queued for reassembly. */ /* and adjust the number of pbufs currently queued for reassembly. */
clen = pbuf_clen(p); clen = pbuf_clen(p);
LWIP_ASSERT("ip_reass_pbufcount >= clen", ip_reass_pbufcount >= clen); LWIP_ASSERT("ip_reass_pbufcount >= clen", ip_reass_pbufcount >= clen);

2
features/lwipstack/lwip/src/core/lwip_dns.c
View File

@ -431,7 +431,7 @@ dns_add_interface_server(u8_t numdns, const char *interface_name, const ip_addr_
} }
// add new dns server to the list tail // add new dns server to the list tail
new_interface_server = mem_malloc(sizeof(struct dns_server_interface)); new_interface_server = mem_malloc(sizeof(struct dns_server_interface));
strncpy(new_interface_server->interface_name, interface_name, INTERFACE_NAME_MAX_SIZE); snprintf(new_interface_server->interface_name, INTERFACE_NAME_MAX_SIZE, "%s",interface_name);
new_interface_server->dns_servers[numdns] = (*dnsserver); new_interface_server->dns_servers[numdns] = (*dnsserver);
new_interface_server->next = NULL; new_interface_server->next = NULL;