From 5c2262219d968b83cccc72e83ccb5cdddcfc2ae5 Mon Sep 17 00:00:00 2001 From: Mirela Chirica Date: Tue, 29 May 2018 17:05:16 +0300 Subject: [PATCH] Cellular: BC95 socket creation to fail on missing socket id in the response --- features/cellular/framework/AT/AT_CellularStack.cpp | 9 +++++++++ .../targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/features/cellular/framework/AT/AT_CellularStack.cpp b/features/cellular/framework/AT/AT_CellularStack.cpp index 20c3365186..df9753fa0a 100644 --- a/features/cellular/framework/AT/AT_CellularStack.cpp +++ b/features/cellular/framework/AT/AT_CellularStack.cpp @@ -250,7 +250,10 @@ nsapi_size_or_error_t AT_CellularStack::socket_sendto(nsapi_socket_t handle, con _at.unlock(); if (ret_val != NSAPI_ERROR_OK) { + tr_error("Error creating socket to send to: %s error code: %d", addr.get_ip_address(), ret_val); return ret_val; + } else { + tr_info("Success creating socket to send to: %s", addr.get_ip_address()); } } @@ -265,6 +268,12 @@ nsapi_size_or_error_t AT_CellularStack::socket_sendto(nsapi_socket_t handle, con _at.lock(); ret_val = socket_sendto_impl(socket, addr, data, size); + + if (ret_val <= 0) { + tr_error("Error sending to: %s error code: %d", addr.get_ip_address(), ret_val); + } else { + tr_info("Success sending %d Bytes to: %s", ret_val, addr.get_ip_address()); + } _at.unlock(); diff --git a/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp b/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp index 5e49efb1b5..ccdcb05a10 100644 --- a/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp +++ b/features/cellular/framework/targets/QUECTEL/BC95/QUECTEL_BC95_CellularStack.cpp @@ -119,7 +119,7 @@ nsapi_error_t QUECTEL_BC95_CellularStack::create_socket_impl(CellularSocket *soc } } - if (!socketOpenWorking) { + if (!socketOpenWorking || (sock_id == -1)) { tr_error("Socket create failed!"); return NSAPI_ERROR_NO_SOCKET; }