From 52a7f64d6730fd9c076ab690f797611a5ae4f964 Mon Sep 17 00:00:00 2001
From: Jimmy Brisson <theotherjimmy@gmail.com>
Date: Mon, 20 Jun 2016 18:04:28 -0500
Subject: [PATCH] Generalize parsing types

---
 tools/memap.py | 27 +++++++--------------------
 tools/utils.py | 21 +++++++++++++++++++++
 2 files changed, 28 insertions(+), 20 deletions(-)

diff --git a/tools/memap.py b/tools/memap.py
index 833e33da05..faaf308f53 100644
--- a/tools/memap.py
+++ b/tools/memap.py
@@ -10,6 +10,7 @@ import re
 import csv
 import json
 import argparse
+from utils import argparse_uppercase_type, argparse_lowercase_hyphen_type
 from prettytable import PrettyTable
 
 debug = False
@@ -336,6 +337,8 @@ class MemapParser(object):
                     else:
                         self.object_to_module.update({object_name:module_name})
 
+    export_formats = ["json", "csv-ci", "table"]
+
     def generate_output(self, export_format, file_output=None):
         """
         Generates summary of memory map data
@@ -451,6 +454,8 @@ class MemapParser(object):
 
         return True
 
+    toolchains = ["ARM", "ARM_STD", "ARM_MICRO", "GCC_ARM", "IAR"]
+
     def parse(self, mapfile, toolchain):
         """
         Parse and decode map file depending on the toolchain
@@ -477,24 +482,6 @@ class MemapParser(object):
 
         return True
 
-    toolchains = ["ARM", "ARM_STD", "ARM_MICRO", "GCC_ARM", "IAR"]
-    @staticmethod
-    def parse_toolchain(string) :
-        newstring = string.upper().replace("-","_")
-        if newstring not in MemapParser.toolchains:
-            raise (argparse.ArgumentTypeError("{} is not a supported toolchain. Supported toolchains are {}".format(string, ", ".join(MemapParser.toolchains))))
-        else:
-            return newstring
-
-    export_formats = ["json", "csv-ci", "table"]
-    @staticmethod
-    def parse_export_format(string):
-        newstring = string.lower().replace("_","-")
-        if newstring not in MemapParser.export_formats:
-            raise (argparse.ArgumentTypeError("{} is not a supported export format. Supported export formats are {}".format(string, ", ".join(MemapParser.export_formats))))
-        else :
-            return newstring
-
 def main():
 
     version = '0.3.10'
@@ -505,11 +492,11 @@ def main():
     parser.add_argument('file', help='memory map file')
 
     parser.add_argument('-t', '--toolchain', dest='toolchain', help='select a toolchain used to build the memory map file (%s)' % ", ".join(MemapParser.toolchains),\
-                        required=True, type=MemapParser.parse_toolchain)
+                        required=True, type=argparse_uppercase_type(MemapParser.toolchains, "toolchain"))
 
     parser.add_argument('-o', '--output', help='output file name', required=False)
 
-    parser.add_argument('-e', '--export', dest='export', required=False, default='table', type=MemapParser.parse_export_format,\
+    parser.add_argument('-e', '--export', dest='export', required=False, default='table', type=argparse_lowercase_hyphen_type(MemapParser.export_formats,'export format'),\
                         help="export format (examples: %s: default)" % ", ".join(MemapParser.export_formats))
 
     parser.add_argument('-v', '--version', action='version', version=version)
diff --git a/tools/utils.py b/tools/utils.py
index 55752b8750..c2ae4bd156 100644
--- a/tools/utils.py
+++ b/tools/utils.py
@@ -17,6 +17,7 @@ limitations under the License.
 import sys
 import inspect
 import os
+import argparse
 from os import listdir, remove, makedirs
 from shutil import copyfile
 from os.path import isdir, join, exists, split, relpath, splitext
@@ -196,3 +197,23 @@ def dict_to_ascii(input):
 def json_file_to_dict(fname):
     with open(fname, "rt") as f:
         return dict_to_ascii(json.load(f, object_pairs_hook=OrderedDict))
+
+# Wowza, double closure
+def argparse_list_type(casedness, prefer_hyphen=False) :
+    def middle(list, type_name):
+        def parse_type(string):
+            if prefer_hyphen: newstring = casedness(string).replace("_","-")
+            else:             newstring = casedness(string).replace("-","_")
+            if string in list:
+                return string
+            elif string not in list and newstring in list:
+                raise argparse.ArgumentTypeError("{0} is not a supported {1}. Did you mean {2}?".format(string, type_name, newstring))
+            else:
+                raise argparse.ArgumentTypeError("{0} is not a supported {1}. Supported {1}s are {2}.".format(string, type_name, ", ".join(list)))
+        return parse_type
+    return middle
+
+argparse_uppercase_type = argparse_list_type(str.upper, False)
+argparse_lowercase_type = argparse_list_type(str.lower, False)
+argparse_uppercase_hyphen_type = argparse_list_type(str.upper, True)
+argparse_lowercase_hyphen_type = argparse_list_type(str.lower, True)