ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

unittests: Check NULL pointer scenario in TCPSocket::recvfrom

pull/8341/head
Michal Paszta 2018-09-12 15:08:27 +02:00 committed by adbridge
parent 2bbf033fe2
commit 46b529a1ea
1 changed files with 22 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
UNITTESTS/features/netsocket/TCPSocket/test_TCPSocket.cpp
View File

@ -214,13 +214,33 @@ TEST_F(TestTCPSocket, recv_would_block)
EXPECT_EQ(socket->recv(dataBuf, dataSize), NSAPI_ERROR_WOULD_BLOCK);
}
TEST_F(TestTCPSocket, recv_from)
TEST_F(TestTCPSocket, recv_from_no_socket)
{
stack.return_value = NSAPI_ERROR_OK;
SocketAddress a("127.0.0.1", 1024);
EXPECT_EQ(socket->recvfrom(&a, dataBuf, dataSize), NSAPI_ERROR_NO_SOCKET);
}
TEST_F(TestTCPSocket, recv_from)
{
stack.return_value = NSAPI_ERROR_OK;
SocketAddress a("127.0.0.1", 1024);
EXPECT_EQ(socket->open((NetworkStack *)&stack), NSAPI_ERROR_OK);
EXPECT_EQ(socket->connect(a), NSAPI_ERROR_OK);
SocketAddress b;
EXPECT_EQ(socket->recvfrom(&b, dataBuf, dataSize), NSAPI_ERROR_OK);
EXPECT_EQ(a, b);
}
TEST_F(TestTCPSocket, recv_from_null)
{
stack.return_value = NSAPI_ERROR_OK;
SocketAddress a("127.0.0.1", 1024);
EXPECT_EQ(socket->open((NetworkStack *)&stack), NSAPI_ERROR_OK);
EXPECT_EQ(socket->connect(a), NSAPI_ERROR_OK);
EXPECT_EQ(socket->recvfrom(NULL, dataBuf, dataSize), NSAPI_ERROR_OK);
}
/* listen */
TEST_F(TestTCPSocket, listen_no_open)
@ -236,9 +256,7 @@ TEST_F(TestTCPSocket, listen)
EXPECT_EQ(socket->listen(1), NSAPI_ERROR_OK);
}
/* accept - will accept ever be used on TCPSocket, or is it just meant for TCPServer?
* accept currently always returns NULL - is this intended? Memory leak
* Perhaps we should make it return UNSUPPORTED ? */
/* these tests will have to be readjusted after TCPServer is deprecated. */
TEST_F(TestTCPSocket, accept_no_open)
{