From 3bdb6d1737b0132230fe5bcd04c7ed61ab268d9a Mon Sep 17 00:00:00 2001
From: Ari Parkkila <ari.parkkila@arm.com>
Date: Thu, 3 May 2018 15:43:48 +0300
Subject: [PATCH] Cellular: Fixed ATHandler write poll timeout

---
 features/cellular/framework/AT/ATHandler.cpp | 28 ++++++++++----------
 features/cellular/framework/AT/ATHandler.h   |  3 +++
 2 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/features/cellular/framework/AT/ATHandler.cpp b/features/cellular/framework/AT/ATHandler.cpp
index cccd7314f8..4086ff3a30 100644
--- a/features/cellular/framework/AT/ATHandler.cpp
+++ b/features/cellular/framework/AT/ATHandler.cpp
@@ -335,14 +335,8 @@ void ATHandler::rewind_buffer()
     }
 }
 
-bool ATHandler::fill_buffer(bool wait_for_timeout)
+int ATHandler::poll_timeout(bool wait_for_timeout)
 {
-    tr_debug("%s", __func__);
-    // Reset buffer when full
-    if (sizeof(_recv_buff) == _recv_len) {
-        reset_buffer();
-    }
-
     int timeout;
     if (wait_for_timeout) {
         uint64_t now = rtos::Kernel::get_ms_count();
@@ -356,11 +350,22 @@ bool ATHandler::fill_buffer(bool wait_for_timeout)
     } else {
         timeout = 0;
     }
+    return timeout;
+}
+
+bool ATHandler::fill_buffer(bool wait_for_timeout)
+{
+    tr_debug("%s", __func__);
+    // Reset buffer when full
+    if (sizeof(_recv_buff) == _recv_len) {
+        reset_buffer();
+    }
 
     pollfh fhs;
     fhs.fh = _fileHandle;
     fhs.events = POLLIN;
-    int count = poll(&fhs, 1, timeout);
+    int timeout = 0;
+    int count = poll(&fhs, 1, poll_timeout(wait_for_timeout));
     if (count > 0 && (fhs.revents & POLLIN)) {
         ssize_t len = _fileHandle->read(_recv_buff + _recv_len, sizeof(_recv_buff) - _recv_len);
         if (len > 0) {
@@ -1097,12 +1102,7 @@ size_t ATHandler::write(const void *data, size_t len)
     fhs.events = POLLOUT;
     size_t write_len = 0;
     for (; write_len < len; ) {
-        int timeout = (_start_time + _at_timeout) - rtos::Kernel::get_ms_count();
-        if (timeout < 0) {
-            set_error(NSAPI_ERROR_DEVICE_ERROR);
-            return 0;
-        }
-        int count = poll(&fhs, 1, timeout);
+        int count = poll(&fhs, 1, poll_timeout());
         if (count <= 0 || !(fhs.revents & POLLOUT)) {
             set_error(NSAPI_ERROR_DEVICE_ERROR);
             return 0;
diff --git a/features/cellular/framework/AT/ATHandler.h b/features/cellular/framework/AT/ATHandler.h
index ded46e2913..6208223d8d 100644
--- a/features/cellular/framework/AT/ATHandler.h
+++ b/features/cellular/framework/AT/ATHandler.h
@@ -430,6 +430,9 @@ private:
     void reset_buffer();
     // Reading position set to 0 and buffer's unread content moved to beginning
     void rewind_buffer();
+    // Calculate remaining time for polling based on request start time and AT timeout.
+    // Returns 0 or time in ms for polling.
+    int poll_timeout(bool wait_for_timeout = true);
     // Reads from serial to receiving buffer.
     // Returns true on successful read OR false on timeout.
     bool fill_buffer(bool wait_for_timeout = true);