ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

CellularUtil prefer_ipv6: check length. 

Fixes Coverity issue about not checking the length of string before copying it.
pull/11696/head
int_szyk 2019-09-24 10:44:38 +02:00 committed by adbridge
parent ce73f8ecdd
commit 2d2fdf7cf9
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
features/cellular/framework/common/CellularUtil.cpp
View File

@ -236,7 +236,7 @@ void prefer_ipv6(char *ip, size_t ip_size, char *ip2, size_t ip2_size)
if (temp) {
// ipv6 was found in ip2 but not in ip ---> we must swap them. Sadly ip and ip2 might not be pointers
// so we can't just swap them, must use copy.
if (strlen(ip) < ip2_size && strlen(ip2) < ip_size && strlen(ip) < 64) {
if (strlen(ip) < ip2_size && strlen(ip2) < ip_size && strlen(ip) < 64 && strlen(ip2) < 64) {
char tmp[64];
strncpy(tmp, ip, strlen(ip));
tmp[strlen(ip)] = '\0';