ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

M2351: Refine gpio_irq_set(...) with inconsistent GPIO_EnableInt(...) implementations 

No logic change
pull/12424/head
Chun-Chieh Li 2020-02-12 13:48:38 +08:00
parent 582c08c129
commit 28495bb075
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
targets/TARGET_NUVOTON/TARGET_M2351/gpio_irq_api.c
View File

@ -182,7 +182,13 @@ void gpio_irq_set(gpio_irq_t *obj, gpio_irq_event event, uint32_t enable)
obj->irq_types &= ~irq_type;
}
/* Update irq types */
/* Update irq types:
*
* Implementations of GPIO_EnableInt(...) are inconsistent: disable or not irq type not enabled.
* For consistency, disable GPIO_INT_BOTH_EDGE and then enable OR'ed irq types, GPIO_INT_RISING,
* GPIO_INT_FALLING, or both.
*/
GPIO_DisableInt(gpio_base, pin_index);
GPIO_EnableInt(gpio_base, pin_index, obj->irq_types);
}