ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #13069 from AriParkkila/fix-unittest-for-CellularNetwork 

Cellular: Fix unittest for CellularNetwork
pull/13095/head
Martin Kojtal 2020-06-10 12:02:26 +02:00 committed by GitHub
parent 93be66e91e 985e72f65d
commit 12910eabbe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
UNITTESTS/features/cellular/framework/AT/at_cellularnetwork/at_cellularnetworktest.cpp
View File

@ -364,7 +364,7 @@ TEST_F(TestAT_CellularNetwork, test_AT_CellularNetwork_get_network_registering_m
ATHandler_stub::nsapi_error_value = NSAPI_ERROR_DEVICE_ERROR; ATHandler_stub::nsapi_error_value = NSAPI_ERROR_DEVICE_ERROR;
mode = CellularNetwork::NWModeManual; mode = CellularNetwork::NWModeManual;
EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == cn.get_network_registering_mode(mode)); EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == cn.get_network_registering_mode(mode));
EXPECT_TRUE(mode == -1); EXPECT_TRUE(mode == CellularNetwork::NWModeManual);
} }
TEST_F(TestAT_CellularNetwork, test_AT_CellularNetwork_set_registration_urc) TEST_F(TestAT_CellularNetwork, test_AT_CellularNetwork_set_registration_urc)

2
features/cellular/framework/API/CellularNetwork.h
View File

@ -200,7 +200,7 @@ public:
/** Get the current network registering mode /** Get the current network registering mode
* *
* @param mode on successful return contains the current network registering mode * @param mode on success the current network registering mode, otherwise unchanged
* @return NSAPI_ERROR_OK on success * @return NSAPI_ERROR_OK on success
* NSAPI_ERROR_DEVICE_ERROR on failure * NSAPI_ERROR_DEVICE_ERROR on failure
*/ */

4
features/cellular/framework/AT/AT_CellularNetwork.cpp
View File

@ -202,7 +202,9 @@ nsapi_error_t AT_CellularNetwork::get_network_registering_mode(NWRegisteringMode
{ {
int ret; int ret;
nsapi_error_t error = _at.at_cmd_int("+COPS", "?", ret); nsapi_error_t error = _at.at_cmd_int("+COPS", "?", ret);
mode = (NWRegisteringMode)ret; if (error == NSAPI_ERROR_OK) {
mode = (NWRegisteringMode)ret;
}
return error; return error;
} }