ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove IAR assembler macros containing quotes 

IAR assembler 7.80 has some problems handling difficult macros, leading
to immediate exit with return value -11.

In particular, a URL string has been causing problems, presumably due to
the "//" resembling a comment.

A previous escaping workaround in 0d97803 seemed to work, but the crash
has still been seen with a particular target.

Previous creation of the extended command line file for the IAR
assembler was stripping quotes from macros. This rendered the resulting
definitions for string-containing macros incorrect, which means that we
can assume no assembler code is currently relying on them.

Therefore, as a precautionary measure to avoid the crash, simply remove
all macros containing strings when creating them for IAR. This
apparently clears the crashes seen during testing of
https://github.com/ARMmbed/mbed-os/pull/8023
pull/8023/head
Kevin Bracey 2018-09-20 13:19:24 +03:00
parent 736fc2a363
commit 0e7eda0749
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/toolchains/iar.py
View File

@ -167,7 +167,7 @@ class IAR(mbedToolchain):
opts = ['-D%s' % d for d in defines] opts = ['-D%s' % d for d in defines]
if for_asm: if for_asm:
config_macros = self.config.get_config_data_macros() config_macros = self.config.get_config_data_macros()
macros_cmd = ['"-D%s"' % d.replace('"', '').replace('//','/\/') for d in config_macros] macros_cmd = ['"-D%s"' % d for d in config_macros if not '"' in d]
if self.RESPONSE_FILES: if self.RESPONSE_FILES:
via_file = self.make_option_file( via_file = self.make_option_file(
macros_cmd, "asm_macros_{}.xcl") macros_cmd, "asm_macros_{}.xcl")