ARMmbed
/
mbed-os
mirror of https://github.com/ARMmbed/mbed-os.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix Coverity uninitialized pointer field Thread.h 

Changed _obj_mem to be initialized with constructor of new thread.
pull/11308/head
int_szyk 2019-08-21 13:05:47 +02:00 committed by adbridge
parent 95b4c7c03c
commit 02822d33ca
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
rtos/Thread.cpp
View File

@ -49,8 +49,9 @@ void Thread::constructor(uint32_t tz_module, osPriority priority,
const uint32_t offset = aligned_mem - unaligned_mem; const uint32_t offset = aligned_mem - unaligned_mem;
const uint32_t aligned_size = ALIGN_DOWN(stack_size - offset, 8); const uint32_t aligned_size = ALIGN_DOWN(stack_size - offset, 8);
_tid = 0; memset(&_obj_mem, 0, sizeof(_obj_mem));
_dynamic_stack = (stack_mem == NULL); _tid = nullptr;
_dynamic_stack = (stack_mem == nullptr);
_finished = false; _finished = false;
memset(&_attr, 0, sizeof(_attr)); memset(&_attr, 0, sizeof(_attr));
_attr.priority = priority; _attr.priority = priority;
@ -104,7 +105,6 @@ osStatus Thread::start(mbed::Callback<void()> task)
((uint32_t *)_attr.stack_mem)[i] = osRtxStackMagicWord; ((uint32_t *)_attr.stack_mem)[i] = osRtxStackMagicWord;
} }
memset(&_obj_mem, 0, sizeof(_obj_mem));
_attr.cb_size = sizeof(_obj_mem); _attr.cb_size = sizeof(_obj_mem);
_attr.cb_mem = &_obj_mem; _attr.cb_mem = &_obj_mem;
_task = task; _task = task;